Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check spelling in UPPER_CASE_SEPARATED_BY_UNDERSCORE #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antoniodgonzalez
Copy link

When using this plugin in my project, I found that upper case identifiers are not being spell checked. I'm using Redux in my project, and here it is a convention to name the actions with upper case, separated by underscore, like:

const MY_ACTION = "MY_ACTION";

I modified the checkSpelling function with a previous transformation to find tokens of the kind UPPER_CASE_SEPARATED_BY_UNDERSCORE and convert to something like upper case separated by underscore, so the next step will be able to check these words. I added a few tests for these cases.

Additionally, I added a test script to the package.json file to ease the test execution.

@aotaduy
Copy link
Owner

aotaduy commented Jul 4, 2016

Thanks for the PR, I think I'll add a configuration option for this kind of strings, since they ussually are constants, and might get funky names on propose.

@aotaduy
Copy link
Owner

aotaduy commented Jul 4, 2016

Could you please add a config option?

@aotaduy
Copy link
Owner

aotaduy commented Aug 12, 2016

Made some changes recently that wouldn't allow merge. Could you please update. If not i will try to integrate your changes.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants