Keep color codes #63
Closed
Keep color codes #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retain hash for color codes embedded in strings or tagged template literals.
The color code check needs to ensure that the code is not simply the beginning of a word whose characters fall into a-f. For example: `#cabbage` is not a valid color code even though it begins with `#cab`.
Spotted a duplicate hex code check in the RegExp
|
Would love to see this merged. |
|
Could this same funcionality be done by configuration using skipIfMatch paramater for the config? and adding the regexp there? Let me check it out |
|
My change simply adds a check for valid color codes and does not change the application logic or configuration parameters. I think it is the least impact change. Everything else in the library seems to work just fine |
|
Yes, I saw your changes but i think we can do the same with a configuration parameter and without changing the code. I will always prefer the configuration solution over changes in the code. I will try to check this on these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain hash for color codes embedded in strings or tagged template literals. Currently these hash symbols are being stripped out incorrectly making it impossible to know that a word is in fact a color code.