feat: make operation manifest format configurable #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `operationManifestFormat` as a compilerParam that accepts a String that will determine which format will be used to generate the manifest. This change also fixes the manifest generation logic, as it didn't work before.
|
|
I made the change backwards compatible so you don't have to make another major release, but the configuration right now is not really optimal. I think we could get rid of What do you think @aoudiamoncef? |
|
@rruizt I'll review this ASAP. |
|
Thanks @rruizt for your contribution 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
operationManifestFormatas a compilerParam that accepts a String that will determine which format will be used to generate the manifest.This change also fixes the manifest generation logic, as it didn't work before.