Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-fexceptions is missing when configuring the wasm build #147

Closed
palemieux opened this issue Jul 7, 2024 · 2 comments
Closed

-fexceptions is missing when configuring the wasm build #147

palemieux opened this issue Jul 7, 2024 · 2 comments

Comments

@palemieux
Copy link
Contributor

-fexceptions is necessary otherwise exceptions that are thrown in the code are not caught within the code.

set_target_properties(libopenjph PROPERTIES SUFFIX ".js" LINK_FLAGS "-O3 -s WASM=1 -s EXPORT_ES6=1 -s MODULARIZE=1 -s ENVIRONMENT=web -s EXPORTED_FUNCTIONS=[_free,_malloc] -s EXPORTED_RUNTIME_METHODS=[ccall,cwrap,writeArrayToMemory] -s NO_EXIT_RUNTIME=1 -s ALLOW_MEMORY_GROWTH=1 -s INITIAL_MEMORY=134217728")

@aous72
Copy link
Owner

aous72 commented Jul 7, 2024

Hi Pierre,

Thank you for putting this. It is an oversight on my part.
I have the flag for the library, but forgot to add it here.
I will fix it soon.

Kind regards,
Aous.

aous72 added a commit that referenced this issue Jul 21, 2024
@aous72
Copy link
Owner

aous72 commented Jul 21, 2024

This issue was addressed in release 0.15.0.
If there are any issues, please reopen this issue.

@aous72 aous72 closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants