Adding NLT implementation to the lossy path #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds NLT implementation to the lossy path.
I also took the time to change the lossy path to support 32bit integer source data; the previous code may have had issues with 32bit integers in certain cases. It is worth noting that the lossy path is implemented using single precision floats, which has 23bit mantissa, making 32bit source numbers excessive.
This is a rather large PR.
Hopefully nothing broken.
I need to add automated tests for these new paths.
I also need to change the apps, but this will wait until version 0.20.0.