Skip to content

Commit

Permalink
ci: fix poetry usage (hyperledger-iroha#5285)
Browse files Browse the repository at this point in the history
* fix: update poetry usage
* fix: remove iroha github link checking
* fix: remove iroha github link checking (2)
* fix: revert iroha github link checking

Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
  • Loading branch information
aoyako authored Jan 28, 2025
1 parent d96f6f7 commit 2891a07
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/iroha2-dev-pr-static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
working-directory: pytests/${{ matrix.suite }}
run: |
poetry lock --no-update
poetry install
poetry install --no-root
- name: Check code formatting with Black in pytests/${{ matrix.suite }}
working-directory: pytests/${{ matrix.suite }}
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/iroha2-dev-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ jobs:
run: docker compose -f ${{ env.DEFAULTS_DIR }}/docker-compose.yml up --wait || exit 1
- name: Install Torii pytest dependencies
working-directory: pytests/iroha_torii_tests
run: ${{ env.POETRY_PATH }} install
run: ${{ env.POETRY_PATH }} install --no-root
- name: Run Torii pytests
working-directory: pytests/iroha_torii_tests
run: ${{ env.POETRY_PATH }} run pytest
Expand All @@ -240,7 +240,7 @@ jobs:
chmod +x ${{ env.TEST_DIR }}/${{ env.IROHA_BIN }}
- name: Install client pytest dependencies
working-directory: pytests/iroha_cli_tests
run: ${{ env.POETRY_PATH }} install
run: ${{ env.POETRY_PATH }} install --no-root
- name: Run client pytests
uses: nick-fields/retry@v3
env:
Expand Down
2 changes: 1 addition & 1 deletion crates/iroha_core/src/smartcontracts/wasm/cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::{

/// Executor related things (linker initialization, module instantiation, memory free)
/// takes significant amount of time in case of single peer transactions handling.
/// (https://github.com/hyperledger/iroha/issues/3716#issuecomment-2348417005).
/// (https://github.com/hyperledger-iroha/iroha/issues/3716#issuecomment-2348417005).
/// So this cache is used to share `Store` and `Instance` for different transaction validation.
#[derive(Default)]
pub struct WasmCache<'world, 'block, 'state> {
Expand Down
2 changes: 1 addition & 1 deletion pytests/iroha_cli_tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ To get started with Poetry, follow these steps:
3. Install the dependencies and set up a virtual environment using Poetry:

```bash
poetry install
poetry install --no-root
```

4. Activate the virtual environment:
Expand Down
2 changes: 1 addition & 1 deletion pytests/iroha_torii_tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ These instructions will get you a copy of the project up and running on your loc
First, use Poetry to install the dependencies:

```bash
poetry install
poetry install --no-root
```

This command will create a virtual environment and install all the necessary dependencies.
Expand Down

0 comments on commit 2891a07

Please sign in to comment.