Skip to content

Improve error message when a wrong type is passed to Spectrometer #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve error message when a wrong type is passed to Spectrometer #292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1965df9
Put backquotes around device
ederag Jul 17, 2025
91c23fa
Append device representation to the TypeError
ederag Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/seabreeze/spectrometers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ def __init__(self, device: SeaBreezeDevice) -> None:
a SeaBreezeDevice as returned from `list_devices`
"""
if not isinstance(device, self._backend.SeaBreezeDevice):
raise TypeError("device has to be a `SeaBreezeDevice`")
raise TypeError(
f"`device` has to be a `SeaBreezeDevice` instance, got {device!r}"
)
self._dev = device
self.open() # always open the device here to allow caching values

Expand Down