Add show_toast entity action type
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added a custom toast, with configurable title, description, icon, duration and sound + Added `show_toast` entity action type for displaying a custom toast
From "DynamicToast..." to "CustomToast..."
+ Added `texture` field; used for specifying a custom texture for the custom toast - Removed `sound_event` field, as it isn't really necessary * The size of the toast now depends on the length of the description
eggohito
force-pushed
the
feat/entity_action_types/show_toast
branch
from
fc2fdbf to
fbf3b03
Compare
+ Added helper methods for creating custom toast data from a serializable data instance, and converting a custom toast data to a serializable data instance * Fixed issue with adjusting the height of the rendered toast * Made `show_toast` entity action type accept the fields of a custom toast data directly, instead of nesting it in a `toast` field
…ow_toast # Conflicts: # src/main/java/io/github/apace100/apoli/mixin/ServerPlayerEntityMixin.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
show_toastentity action type, and new classes:CustomToastfor displaying a toast with configurable text and duration,CustomToastData, used for serializing data to be used for displayingCustomToasts, andCustomToastViewer(duck interface), mostly for implementing S2C packet transaction for displaying a toast from the server to the clientThe
show_toastentity action type accepts these fields:titledescriptiontexture"apoli:toast/custom"iconduration5000