Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duration and duration_on_use fields to spawn_effect_cloud entity action. #225

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add duration and duration_on_use fields to spawn_effect_cloud entity action. #225

merged 3 commits into from
Jun 28, 2024

Conversation

MerchantPug
Copy link
Contributor

@MerchantPug MerchantPug commented May 5, 2024 •
edited by eggohito
Loading

Resolves #198

I moved the action to its own class too! These fields function as follows:

Field Type Default Description
duration Integer 600 Determines how long the area effect cloud will last (after wait_time.)
duration_on_use Integer 0 Determines the amount of change to the duration of the area effect cloud when applying the effects.

@MerchantPug MerchantPug changed the title Add duration and duration_on_use fields to spawn_effect_cloud. Add duration and duration_on_use fields to spawn_effect_cloud entity action. May 5, 2024
@eggohito eggohito self-assigned this May 5, 2024
@eggohito eggohito added this to the 2.12.x milestone May 5, 2024
@eggohito eggohito changed the base branch from 1.20 to 1.20.4/dev May 17, 2024 04:37
eggohito added 2 commits June 25, 2024 18:29
@eggohito
Merge branch 'refs/heads/1.20.4/dev' into fork/MerchantPug/feat/spawn…
d1a8c49 
…_effect_cloud_duration

# Conflicts:
#	src/main/java/io/github/apace100/apoli/power/factory/action/EntityActions.java
@eggohito
Optimized imports in EntityActions
00987bb
@eggohito eggohito added the pending: merge This will be merged soon label Jun 25, 2024
@eggohito eggohito merged commit f217048 into apace100:1.20.4/dev Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eggohito eggohito

Labels
pending: merge This will be merged soon
Projects
None yet
Milestone
2.12.x
Development

Successfully merging this pull request may close these issues.

Customize duration of spawn_effect_cloud
2 participants
@MerchantPug @eggohito