Refactor recipe serializers and make power crafting recipes visible in the recipe book #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added `neo_recipe` power type temporarily.
+ Added `power_crafting` recipe serializer with the following fields:
* `power` - The power ID that corresponds to the recipe (The power must exist and use the `neo_recipe` power type, otherwise, it will cause an error.)
* `recipe` - The recipe. (Must be a crafting recipe, otherwise, it will cause an error.)
* Renamed `modified` recipe serializer to `modified_crafting`.
* Renamed `power_restricted` recipe serializer to `legacy_power_crafting` and deprecated it in favor of using the `power_crafting` recipe serializer.
…alizers # Conflicts: # src/main/java/io/github/apace100/apoli/Apoli.java # src/main/java/io/github/apace100/apoli/data/ApoliDataTypes.java # src/main/java/io/github/apace100/apoli/mixin/ServerPlayerEntityMixin.java # src/main/java/io/github/apace100/apoli/power/factory/PowerFactories.java # src/main/java/io/github/apace100/apoli/power/type/RecipePowerType.java # src/main/java/io/github/apace100/apoli/util/LegacyPowerCraftingRecipe.java # src/main/java/io/github/apace100/apoli/util/ModifiedCraftingRecipe.java # src/main/resources/apoli.mixins.json
* No longer uses a single instance structure; instead, uses a delegating crafting recipe for modifying the result stack of the affected crafting recipe * Now affects the result stacks in the widgets of the recipe book * Fixed `item_action_after_crafting`/`item_action_after_grinding` item actions not being executed
…alizers # Conflicts: # src/main/java/io/github/apace100/apoli/Apoli.java # src/main/java/io/github/apace100/apoli/util/ApoliCodecs.java # src/main/java/io/github/apace100/apoli/util/MiscUtil.java
* Power recipes are now defined in powers again * Power recipes are inserted into the recipe manager post-power reload, instead of validating already defined recipes
|
I've decided to keep the old format for defining recipes in powers. Also, power crafting recipes will no longer be allowed to be used in recipe JSONs since power crafting recipes will be automatically registered to the recipe manager after all powers have been reloaded |
eggohito
changed the title
power_crafting recipe serializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
modified_crafting(previouslymodified) recipe serializer.