Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Table filter not working #125

Closed
gbrian opened this issue Jun 11, 2019 · 2 comments
Closed

Table filter not working #125

gbrian opened this issue Jun 11, 2019 · 2 comments
Labels
#bug Something isn't working

Comments

@gbrian
Copy link

gbrian commented Jun 11, 2019

Describe the bug
Table filter does not remove filters and dashboards ends up storing the filters on metadata.

To Reproduce

  1. Add a Table slice to dashboard with "Emit Filter" option enabled
  2. Click on row (dashboard is filtered)
  3. Click again same row (nothing happens)
  4. Dashboard keeps filter forever

Expected behavior
Add/Remove filter

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • superset-ui version: latest
  • Node version: node -v
  • npm version: npm -v

Additional context
onRemoveFilter is never passed to the Table control. transformPropsdoes not map any removeFilter option
@issue-label-bot issue-label-bot bot added the #bug Something isn't working label Jun 11, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@cmyip cmyip mentioned this issue Sep 21, 2019
Closed
cmyip added a commit to cmyip/superset-ui-plugins that referenced this issue Sep 22, 2019
@cmyip
fix(apache-superset#125): emit remove filter
0c6ae0f
@cmyip cmyip mentioned this issue Sep 22, 2019
Open
cmyip added a commit to cmyip/superset-ui-plugins that referenced this issue Sep 22, 2019
@cmyip
fix(apache-superset#125): emit onAdd events instead of onRemove
2defe97 
Signed-off-by: Chok Yip <cxyip1@gmail.com>
cmyip added a commit to cmyip/superset-ui-plugins that referenced this issue Sep 22, 2019
@cmyip
fix(apache-superset#125): fix no-eq-null
7b7ced9 
Signed-off-by: Chok Yip <cxyip1@gmail.com>
@cmyip cmyip mentioned this issue Sep 22, 2019
Closed
12 tasks
@jackyq2015 jackyq2015 mentioned this issue Dec 4, 2019
Closed
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this issue Apr 27, 2020
@khtruong @kristw
feat: add labels to color scheme (apache-superset#125)
98a14a2
@ghost ghost mentioned this issue Apr 28, 2020
Closed
@ghost ghost deleted a comment from kristw Apr 28, 2020
@ghost
Copy link

ghost commented Apr 28, 2020

This issue was moved by kristw to apache-superset/superset-ui#407.

@ghost ghost closed this as completed Apr 28, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
#bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbrian