Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

superset-ui-connection: Allow callAPI to handle PUT and PATCH requests to support superset SQLlab #104

Closed
fabiomendescom opened this issue Feb 17, 2019 · 3 comments
Labels
#enhancement New feature or request

Comments

@fabiomendescom
Copy link
Contributor

fabiomendescom commented Feb 17, 2019

Is your feature request related to a problem? Please describe.
The call API in super ui connection component currently only supports the POST command. SQLlab in superset, when saving queries, executes a PUT request to save queries. Because that function uses this component, this component needs to be changed to allow for PUT and PATCH to be executed as well. By support I mean parsing the payload in json into form variables for the request. The call API only does this for POST only. See this for the problem in superset -> apache/superset#5804

Describe the solution you'd like
The call API should work exactly the same (parsing JSON payload into form parameters) for PUT and PATCH the same way

Describe alternatives you've considered
SQLlab is already developed with SQLAlchemy to use these other verbs automatically in the framework. Changing this outside of the callAPI would be too cumbersome and unnecessary, considering that this support should exist in this component.

Additional context
The change is fairly simple. The call API should simply allow these additional verses to be used. See the

@fabiomendescom
Copy link
Contributor Author

#105 pull request created

@kristw
Copy link
Contributor

kristw commented Feb 19, 2019

related to #85

@kristw kristw added the #enhancement New feature or request label Feb 20, 2019
@kristw kristw closed this as completed Mar 7, 2019
@kristw
Copy link
Contributor

kristw commented Mar 7, 2019

Released with @superset-ui/connection 0.10.2

kristw added a commit that referenced this issue Apr 17, 2020
* refactor: use composition package

* refactor: remove WithLegend and ChartFrame
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants