Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(superset-ui-connection): Allow PUT and PATCH in call API #105

Merged
merged 2 commits into from
Mar 4, 2019
Merged

feat(superset-ui-connection): Allow PUT and PATCH in call API #105

merged 2 commits into from
Mar 4, 2019

Conversation

fabiomendescom
Copy link
Contributor

@fabiomendescom fabiomendescom commented Feb 17, 2019 •
edited by kristw
Loading

🏆 Enhancements

Feat: Support PUT and PATCH. Address #104

@fabiomendescom fabiomendescom requested a review from a team as a code owner February 17, 2019 21:53
This was referenced Feb 17, 2019
Closed
Closed
@codecov
Copy link

codecov bot commented Feb 17, 2019 •
edited
Loading

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #105   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          73     73           
  Lines         890    891    +1     
  Branches      204    205    +1     
=====================================
+ Hits          890    891    +1
Impacted Files Coverage Δ
...ages/superset-ui-connection/src/callApi/callApi.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1ef3b...5918cff. Read the comment docs.

kristw
kristw reviewed Feb 19, 2019
View reviewed changes
package.json Outdated
@@ -94,5 +94,8 @@
"yarn run prettier --write",
"git add"
]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this should be installed via the travis.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im a bit confused about this. This file was not modified in this PR. What do I need to do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just remove this added dependency, it seems to have found it's way into the commit/PR even if you didn't intend it to?

@kristw
Copy link
Contributor

kristw commented Feb 25, 2019

@fabiomendescom Your changes look good. Please address the codecov issue above and we can merge.

@fabiomendescom
Copy link
Contributor Author

@fabiomendescom Your changes look good. Please address the codecov issue above and we can merge.

I'm not sure what I need to address. It says 100% coverage. What exactly do I need to do?

@ghost
Copy link

ghost commented Mar 4, 2019

There were the following issues with this Pull Request

  • Commit: 672f55a
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@kristw kristw changed the title Fixes issue #104 Allow PUT and PATCH in call API in superset ui connection fix(superset-ui-connection): Allow PUT and PATCH in call API Mar 4, 2019
@kristw kristw changed the title fix(superset-ui-connection): Allow PUT and PATCH in call API feat(superset-ui-connection): Allow PUT and PATCH in call API Mar 4, 2019
@kristw kristw merged commit efcfd1a into apache-superset:master Mar 4, 2019
@fabiomendescom fabiomendescom mentioned this pull request Mar 5, 2019
Closed
kristw added a commit that referenced this pull request Apr 17, 2020
@kristw
feat: support line strokeWidth (#105)
cbd7368
@xiezhongfu xiezhongfu mentioned this pull request May 17, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster left review comments

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabiomendescom @kristw @williaster