fix(time-format): remove week number

[ktmud]

🐛 Bug Fix

Most databases, including ISO standards, actually uses Monday as the first day of a week. The default week time grain in Superset (P1W) should translate to Monday-based weeks, too.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/6yzv0sf7l
✅ Preview: https://superset-ui-git-fork-ktmud-time-format-week-base.superset.now.sh

[codecov]

Codecov Report

Merging #493 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   22.72%   22.70%   -0.03%     
==========================================
  Files         276      276              
  Lines        6670     6668       -2     
  Branches      644      644              
==========================================
- Hits         1516     1514       -2     
  Misses       5115     5115              
  Partials       39       39              

Impacted Files	Coverage Δ
...at/src/factories/getTimeFormatterForGranularity.ts	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b42bc1...e21b843. Read the comment docs.

[michellethomas]

Thanks I checked presto and it looks like the logic for presto is date_trunc('week', CAST({col} AS TIMESTAMP)) and when I tested it out it looks like week starts on Monday. Do we know if this is true for all supported db_engine_specs? It seems like if any of them evaluate to week start Sunday, this would be incorrect. Can we just show the date for the start of the week (to make sure we will always be accurate)?

[ktmud]

Can we just show the date for the start of the week (to make sure we will always be accurate)?

That was fixed in #486 .

Do we know if this is true for all supported db_engine_specs?

I also checked Druid, MySQL, PostgreSQL, SQL Lite and some other databases, with the exception of MySQL and Drill, all others are using Monday-based weekdays.

Given how most businesses operate and that Monday-based is also the ISO standard, I propose we move forward with this change and change MySQL & Drill to be Monday-based, too.

cc @mistercrunch @john-bodley @kristw

[ktmud]

Another option is to simply remove the week numbers, as: 1) it is not useful for most business settings anyway; 2) different businesses may have different definition of week-of-years.

[kristw]

I agree with removing Wxxx

[michellethomas]

Thanks for resolving this! This seems like a good solution.