feat: bump superset-ui/time-format and big-number #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmud
force-pushed
the
bignumber-tooltip-format
branch
from
482de02 to
3b0aa77
Compare
mistercrunch
approved these changes
May 15, 2020
ktmud
force-pushed
the
bignumber-tooltip-format
branch
from
3b0aa77 to
d205de6
Compare
Codecov Report
@@ Coverage Diff @@
## master #9808 +/- ##
==========================================
+ Coverage 70.89% 71.02% +0.13%
==========================================
Files 585 184 -401
Lines 30427 17863 -12564
Branches 3152 0 -3152
==========================================
- Hits 21572 12688 -8884
+ Misses 8744 5175 -3569
+ Partials 111 0 -111
Continue to review full report at Codecov.
|
This is for adding full dates to big number datetime formatted by weekly interval.
ktmud
force-pushed
the
bignumber-tooltip-format
branch
from
ba43371 to
a70a592
Compare
kristw
approved these changes
May 18, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* feat: bump superset-ui/time-format and big-number This is for adding full dates to big number datetime formatted by weekly interval. * Bump time-format to v0.13.15 to bring in apache-superset/superset-ui#493
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Bump
superset-ui/time-formatand the big number chart to add full dates to big number datetime formatted in weekly interval (and remove week numbers).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See apache-superset/superset-ui#486
and apache-superset/superset-ui#493
TEST PLAN
Unit tests were added to
superset-ui.ADDITIONAL INFORMATION
- feat(time-format): add full-date to weekly time formatter apache-superset/superset-ui#486
- fix(time-format): remove week number apache-superset/superset-ui#493