Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-plugin-chart-parallel-coordinates): add control panels #510

Conversation

pkdotson
Copy link
Contributor

@pkdotson pkdotson commented May 20, 2020

💔 Breaking Changes

🏆 Enhancements
Add control to parallel coordinates chart
📜 Documentation

🐛 Bug Fix

🏠 Internal

@pkdotson pkdotson requested a review from a team as a code owner May 20, 2020 03:44
@vercel
Copy link

vercel bot commented May 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/fzx25xkc8
✅ Preview: https://superset-ui-git-fork-preset-io-phillip-so-508-paralle-bfd0bb.superset.now.sh

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #510 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   22.66%   22.63%   -0.03%     
==========================================
  Files         279      281       +2     
  Lines        6679     6692      +13     
  Branches      644      648       +4     
==========================================
+ Hits         1514     1515       +1     
- Misses       5126     5138      +12     
  Partials       39       39              
Impacted Files Coverage Δ
...acy-plugin-chart-parallel-coordinates/src/index.js 0.00% <ø> (ø)
plugins/legacy-plugin-chart-table/src/index.ts 0.00% <0.00%> (ø)
packages/superset-ui-query/src/buildQueryObject.ts 100.00% <0.00%> (ø)
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <0.00%> (ø)
packages/superset-ui-query/src/processMetrics.ts
...ckages/superset-ui-query/src/extractQueryFields.ts 100.00% <0.00%> (ø)
packages/superset-ui-query/src/processGroupby.ts 100.00% <0.00%> (ø)
...ins/legacy-plugin-chart-table/src/controlPanel.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34541df...39adefe. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristw kristw changed the title chore: add controls to chart for para feat(legacy-plugin-chart-parallel-coordinates): add control panels May 20, 2020
@kristw kristw merged commit b9bc48d into apache-superset:master May 21, 2020
@rusackas rusackas deleted the phillip/SO-508-ParallelCoordinate-control-migration branch July 17, 2020 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants