Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove para controls #9851

Conversation

pkdotson
Copy link
Member

SUMMARY

Remove controls from superset. will update version number once super-ui pr is merged

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #9851 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9851      +/-   ##
==========================================
- Coverage   71.21%   71.21%   -0.01%     
==========================================
  Files         584      584              
  Lines       30791    30790       -1     
  Branches     3238     3238              
==========================================
- Hits        21927    21926       -1     
  Misses       8754     8754              
  Partials      110      110              
Flag Coverage Δ
#cypress 53.83% <ø> (-0.01%) ⬇️
#javascript 59.44% <ø> (+<0.01%) ⬆️
#python 71.32% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/setup/setupPlugins.ts 18.18% <ø> (+0.79%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 86.51% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 333dc85...6145d71. Read the comment docs.

@pkdotson pkdotson force-pushed the phillip/SO-508-ParallelCoordinate-control-migration branch from a0f426c to 6145d71 Compare May 21, 2020 20:15
@pkdotson pkdotson changed the title WIP: remove para controls feat: remove para controls May 21, 2020
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rusackas rusackas merged commit 1fffa37 into apache:master May 26, 2020
@rusackas rusackas deleted the phillip/SO-508-ParallelCoordinate-control-migration branch May 26, 2020 19:37
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* remove para controls

* update package version
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants