This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
chore: adds Emotion's CacheProvider and createCache as exports from Core package #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/7d3Lfzb1i2nB4Fz2s4b24b4oCzdB |
pkdotson
approved these changes
Apr 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
=======================================
Coverage 27.80% 27.80%
=======================================
Files 453 453
Lines 9104 9104
Branches 1416 1416
=======================================
Hits 2531 2531
Misses 6381 6381
Partials 192 192
Continue to review full report at Codecov.
|
nytai
reviewed
Apr 27, 2021
| @@ -32,6 +32,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.1.2", | |||
| "@emotion/cache": "^11.1.3", | |||
There was a problem hiding this comment.
Tested locally, this should work!
nytai
reviewed
Apr 27, 2021
This was referenced Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
We're now exporting cache features to namespace classes and such. We're also continuing this habit of exporting all things Emotion from Superset-UI Core to avoid multiple instantiated versions in Superset, which causes hard-to-diagnose bugs.
📜 Documentation
🐛 Bug Fix
🏠 Internal