feat(plugin-chart-table): disable show_totals by default

[ktmud]

🐛 Bug Fix

Show totals adds an additional SQL query to the request, which slows things down. Since it's not a critical feature, we shouldn't enable it by default.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Hgz7bhyRQDXvXAzS5ZghXpSZFi7Z
✅ Preview: https://superset-ui-git-show-totals-off-by-default-superset.vercel.app

[codecov]

Codecov Report

Merging #1078 (2fd1542) into master (af9ced7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1078   +/-   ##
=======================================
  Coverage   27.80%   27.80%           
=======================================
  Files         453      453           
  Lines        9104     9104           
  Branches     1416     1416           
=======================================
  Hits         2531     2531           
  Misses       6381     6381           
  Partials      192      192           

Impacted Files	Coverage Δ
plugins/plugin-chart-table/src/controlPanel.tsx	0.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9ced7...2fd1542. Read the comment docs.

[zhaoyongjie]

LGTM. thanks Jesse

[junlincc]

@ktmud it IS a critical feature in table :) but I agree that showing total should be a user choice, since we have not had a conclusion what to do with the non-additive columns. and perf is def important.

[zhaoyongjie]

@junlincc
Since this is a database calculate aggregate, there are many database optimization strategies here rather than on the BI side.

[ktmud]

No it is not.

[villebro]

Tableau also has totals disabled by default, which I think makes sense. In general I like the idea that designing charts we want to incrementally add stuff and only prepopulate the options that are needed in the overwhelming majority of cases. I think totals are often not needed, hence would require an extra step for someone who only needs a simpler chart (which is counter intuitive).