Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-echarts): SORT BY METRIC add checkbox to Gauge #1113

Merged
merged 11 commits into from
May 15, 2021

Conversation

stephenLYZ
Copy link
Contributor

@stephenLYZ stephenLYZ commented May 15, 2021

🏆 Enhancements
support sort by metric for the Gauge chart

cc @zhaoyongjie @junlincc

@stephenLYZ stephenLYZ requested a review from a team as a code owner May 15, 2021 13:21
@vercel
Copy link

vercel bot commented May 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/E9FE3JXjbaYKSbXavFTP5ue3JDSB
✅ Preview: https://superset-ui-git-fork-stephenlyz-gauge-sort-by-superset.vercel.app

@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #1113 (b179151) into master (7da2a9d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   28.98%   28.98%   -0.01%     
==========================================
  Files         462      462              
  Lines        9200     9204       +4     
  Branches     1449     1450       +1     
==========================================
+ Hits         2667     2668       +1     
- Misses       6331     6333       +2     
- Partials      202      203       +1     
Impacted Files Coverage Δ
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 100.00% <ø> (ø)
...ugins/plugin-chart-echarts/src/Gauge/buildQuery.ts 75.00% <50.00%> (-25.00%) ⬇️
...ntrols/src/components/CertifiedIconWithTooltip.tsx 20.00% <0.00%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2a9d...b179151. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit e953d05 into apache-superset:master May 15, 2021
@stephenLYZ stephenLYZ deleted the gauge-sort-by branch May 16, 2021 05:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants