Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: fixes metric control when changing viz type to tree chart #1116

Merged
merged 1 commit into from
May 18, 2021

Conversation

michael-s-molina
Copy link
Contributor

@michael-s-molina michael-s-molina commented May 17, 2021

@michael-s-molina michael-s-molina requested a review from a team as a code owner May 17, 2021 14:22
@vercel
Copy link

vercel bot commented May 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/BHsAdwamnqpApNdtb1oALk6KcHn6
✅ Preview: https://superset-ui-git-fork-michael-s-molina-fix-14654-superset.vercel.app

@michael-s-molina michael-s-molina changed the title fix: Fixes metric control when changing viz type to tree chart fix: fixes metric control when changing viz type to tree chart May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1116 (67c9a68) into master (e953d05) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   28.99%   28.99%   -0.01%     
==========================================
  Files         462      462              
  Lines        9207     9208       +1     
  Branches     1451     1452       +1     
==========================================
  Hits         2670     2670              
- Misses       6333     6334       +1     
  Partials      204      204              
Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 27.58% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e953d05...67c9a68. Read the comment docs.

@junlincc junlincc requested review from zhaoyongjie and villebro May 17, 2021 23:03
Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 122460b into apache-superset:master May 18, 2021
@junlincc
Copy link
Contributor

@michael-s-molina let's always include BEFORE and AFTER screenshot/video in each fix PR. thanks!! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tree chart] metric control disappeared
3 participants