feat(core): add orderyby shared control

[zhaoyongjie]

🏆 Enhancements
Add a new shared control "orderby" for non-timeseries chart.

related PR: #1112

Now all non-time series chart, are using the "timeseries_limit_metric" control. I would like to introduce a unified sorting control. So that in the future we can have a unified sorting control (sort columns and metrics).

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/DNwmffspeAjaDcEhZUKdR9DCYdFm
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-addsortbycontrol-superset.vercel.app

[codecov]

Codecov Report

Merging #1122 (d302f86) into master (7da2a9d) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   28.98%   28.99%           
=======================================
  Files         462      462           
  Lines        9200     9209    +9     
  Branches     1449     1453    +4     
=======================================
+ Hits         2667     2670    +3     
- Misses       6331     6334    +3     
- Partials      202      205    +3     

Impacted Files	Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx	27.58% <ø> (-0.99%)	⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx	37.63% <33.33%> (-0.41%)	⬇️
...ugins/plugin-chart-echarts/src/Gauge/buildQuery.ts	75.00% <0.00%> (-25.00%)	⬇️
...ntrols/src/components/CertifiedIconWithTooltip.tsx	20.00% <0.00%> (-13.34%)	⬇️
...plugin-chart-echarts/src/Treemap/transformProps.ts	52.00% <0.00%> (-1.07%)	⬇️
plugins/plugin-chart-echarts/src/Treemap/types.ts	100.00% <0.00%> (ø)
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx	33.33% <0.00%> (ø)
.../plugin-chart-echarts/src/Funnel/transformProps.ts	74.35% <0.00%> (ø)
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx	66.66% <0.00%> (+16.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da2a9d...d302f86. Read the comment docs.

[villebro]

Since this control relates to ordering by metric (as opposed to ordering by e.g. a column name), perhaps we should rename orderby to orderby_metric?

[zhaoyongjie]

no problem at all.

But this control is just for declaring the orderby clause in the SQL, and I guess if we add dimension(column) sorting, we'll probably do it in this control too.

The name of this control, which is also the name of the query object, makes it easier to use.

[villebro]

Good points - if we don't think there will be a need for separate ordering controls for 1) only columns 2) only metrics 3) columns and metrics, then this is probably the right solution for now 👍

[junlincc]

@zhaoyongjie please list all chart that are added this control.

[zhaoyongjie]

@zhaoyongjie please list all chart that are added this control.

there is no chart with this control.