Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add certified icon to columoption #1330

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

pkdotson
Copy link
Contributor

@pkdotson pkdotson commented Aug 26, 2021

💔 Breaking Changes

🏆 Enhancements
This pr adds the cerfiediconwithtool tip to the column option

📜 Documentation

🐛 Bug Fix

🏠 Internal

@pkdotson pkdotson requested review from suddjian and villebro August 26, 2021 05:54
@pkdotson pkdotson requested a review from a team as a code owner August 26, 2021 05:54
@vercel
Copy link

vercel bot commented Aug 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/6F4KcGJrfGctTjSbW6JVi2UTAeeq
✅ Preview: https://superset-ui-git-fork-preset-io-add-icon-columnoption-superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1330 (590c53f) into master (1aad2d1) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1330   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files         488      488           
  Lines        9846     9849    +3     
  Branches     1650     1651    +1     
=======================================
+ Hits         2956     2957    +1     
- Misses       6652     6653    +1     
- Partials      238      239    +1     
Impacted Files Coverage Δ
...-ui-chart-controls/src/components/ColumnOption.tsx 68.75% <33.33%> (-8.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aad2d1...590c53f. Read the comment docs.

@suddjian
Copy link
Member

/testenv up

Copy link
Contributor

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suddjian
Copy link
Member

oops it's superset ui there's no testenv lol

@pkdotson pkdotson merged commit a415c41 into apache-superset:master Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants