Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(core): add support for adhoc columns #1342

Merged
merged 19 commits into from
Nov 10, 2021

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Sep 1, 2021

🏆 Enhancements

Add new type AdhocColumn that can be used as a dimension similar to how AdhocMetric can be used as a (non-saved) metric in query requests.

@villebro villebro requested a review from a team as a code owner September 1, 2021 10:44
@vercel
Copy link

vercel bot commented Sep 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Edr9PDYejhHJY8GBbgrbyAUzsu6X
✅ Preview: https://superset-ui-git-fork-preset-io-hack2021-adhoc-columns-superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1342 (8593fa6) into master (887adbd) will increase coverage by 0.10%.
The diff coverage is 74.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   30.81%   30.91%   +0.10%     
==========================================
  Files         499      503       +4     
  Lines       10193    10215      +22     
  Branches     1760     1761       +1     
==========================================
+ Hits         3141     3158      +17     
- Misses       6800     6805       +5     
  Partials      252      252              
Impacted Files Coverage Δ
...ui-chart-controls/src/operators/boxplotOperator.ts 100.00% <ø> (ø)
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <ø> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <ø> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <ø> (ø)
plugins/plugin-chart-echarts/src/BoxPlot/types.ts 0.00% <ø> (ø)
plugins/plugin-chart-echarts/src/Funnel/types.ts 100.00% <ø> (ø)
plugins/plugin-chart-echarts/src/Gauge/types.ts 100.00% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
plugins/plugin-chart-echarts/src/Pie/types.ts 100.00% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b948ce...8593fa6. Read the comment docs.

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, can't wait to see the whole feature working!

@junlincc
Copy link
Contributor

@villebro it sounds great, can you add a video to demo the. change though?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants