Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: add prop to SuperChart for select #1408

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

pkdotson
Copy link
Contributor

💔 Breaking Changes

🏆 Enhancements
This pr add prop to superchart for form select plugins used in superset. This is related to this open pr to get it to pass ci : apache/superset#17046

📜 Documentation

🐛 Bug Fix

🏠 Internal

@pkdotson pkdotson requested a review from a team as a code owner October 14, 2021 21:13
@vercel
Copy link

vercel bot commented Oct 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/ELoahKpsFN2k8LGm9uktaxsi4va8
✅ Preview: https://superset-ui-git-fork-preset-io-update-superchart-type-superset.vercel.app

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1408 (0f62dab) into master (19e659e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1408   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         497      497           
  Lines        9996     9996           
  Branches     1687     1687           
=======================================
  Hits         3040     3040           
  Misses       6710     6710           
  Partials      246      246           
Impacted Files Coverage Δ
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e659e...0f62dab. Read the comment docs.

@rusackas rusackas merged commit 20acb86 into apache-superset:master Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants