This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-echarts): fix tick labels and tooltip #1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Fixes multiple issues on the Mixed Timeseries chart:
0NaN
when rich tooltip is disabled and the value is a decimal.AFTER
Tooltip correctly shows the x-axis value when the y-value is a decimal:
The erroneous min and max x-axis values are removed, and hovering on a bar underneath a line works as intended:
https://user-images.githubusercontent.com/33317356/139655494-8ab0257a-2ece-4821-a41e-727437cd8490.mp4
BEFORE
Tooltip shows
0NaN
when the metric value is a decimal value:The x-axis shows incorrect min and max values, and hovering on a bar underneath a line doesn't display the bar value correctly:
https://user-images.githubusercontent.com/33317356/139655424-20628415-b6a2-46a7-81e7-fb310e894e19.mp4