-
Notifications
You must be signed in to change notification settings - Fork 273
feat: remove the default Y-axis truncate in bar chart #1450
feat: remove the default Y-axis truncate in bar chart #1450
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/3EsXTNymkD5iVeXCkv1NaEi26s24 |
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 30.62% 30.63%
=======================================
Files 499 500 +1
Lines 10048 10052 +4
Branches 1699 1699
=======================================
+ Hits 3077 3079 +2
- Misses 6723 6725 +2
Partials 248 248
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, y-axis truncation was enabled by default only because it was default behavior in the NVD3 charts. I'm personally against truncation of y-axes by default (I think it's ok in certain cases, but should be a conscious decision), so I'd be happy to see truncation being disabled by default in all charts. But I assume there may be community resistance to this, as changing these types of things have historically proven to be a fairly sensitive topic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, but let's think this through once more before merging to make sure we have broad alignment for changing the default behavior.
Is the tooltip only showing in bar chart? if both behaviors 1)not set by default 2) showing tooltip are only showing in Bar chart, i think we are good. |
So, Do we change the |
750cbe9
to
5f4d881
Compare
5f4d881
to
5b5a34f
Compare
remove the default Y-axis truncate check box to “unchecked” and add a tooltip next to the checkbox saying “It’s not recommended to truncate y-axis in Bar chart”