Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

build: fix lint #245

Merged
merged 1 commit into from
Nov 11, 2019
Merged

build: fix lint #245

merged 1 commit into from
Nov 11, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 11, 2019

🏠 Internal

Fix new linting errors (after some build dependencies upgrade) via yarn lint -- --fix

@kristw kristw requested a review from a team as a code owner November 11, 2019 22:26
@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #245 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #245   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         142    142           
  Lines        1578   1578           
  Branches      409    409           
=====================================
  Hits         1578   1578
Impacted Files Coverage Δ
...set-ui-encodable/src/fillers/completeAxisConfig.ts 100% <ø> (ø) ⬆️
...-ui-encodable/src/encoders/createEncoderFactory.ts 100% <ø> (ø) ⬆️
...es/superset-ui-chart/src/components/SuperChart.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e330ba9...8f4c099. Read the comment docs.

@netlify
Copy link

netlify bot commented Nov 11, 2019

Deploy preview for superset-ui ready!

Built with commit 8f4c099

https://deploy-preview-245--superset-ui.netlify.com

@kristw kristw merged commit 5b104ea into master Nov 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--fix-lint-again branch November 11, 2019 22:33
Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants