This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Add ChartClient (v2) #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
force-pushed
the
kristw--chart-client2
branch
from
6791497 to
67c5377
Compare
kristw
added
reviewable
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 65 66 +1
Lines 629 661 +32
Branches 70 77 +7
=====================================
+ Hits 629 661 +32
Continue to review full report at Codecov.
|
xtinec
suggested changes
Dec 12, 2018
- add formData to chartData
kristw
force-pushed
the
kristw--chart-client2
branch
from
9e0a4ec to
1f346c2
Compare
xtinec
reviewed
Dec 12, 2018
| type BaseFormData = { | ||
| datasource: string; | ||
| // eslint-disable-next-line camelcase |
There was a problem hiding this comment.
[nit] We could disable the camelcase rule for the entire BaseFormData block.
xtinec
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Create
ChartClientto facilitate calls to various APIs necessary for embeddable charts.Refer to this design doc
Working on unit tests.
This PR replaces #44.