Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: Waterfall chart #705

Closed
wants to merge 8 commits into from

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented Jul 27, 2020

feat: Add Waterfall Chart plugin.

Chart Images:
Initial:
thumbnail

Cross filter example:
Screen Shot 2020-07-27 at 14 06 07

Description:

This feature add new plugin of Waterfall Chart that using Recharts library to build this chart.

In Control panel it adds to fields:
xAxisColumn and periodColumn that will be passed as groupBy columns to the DB to get data.

@simcha90 simcha90 requested a review from a team as a code owner July 27, 2020 06:33
@vercel
Copy link

vercel bot commented Jul 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2s0hwtinr
✅ Preview: https://superset-ui-git-fork-simchanielsen-waterfall-chart.superset.vercel.app

@vercel vercel bot temporarily deployed to Preview July 27, 2020 06:33 Inactive
@simcha90 simcha90 changed the title WIP:feat: Waterfall chart WIP: Waterfall chart Jul 27, 2020
@vercel vercel bot temporarily deployed to Preview July 27, 2020 06:38 Inactive
@simcha90 simcha90 changed the title WIP: Waterfall chart WIP: feat: Waterfall chart Jul 27, 2020
@simcha90 simcha90 changed the title WIP: feat: Waterfall chart feat: WIP: Waterfall chart Jul 27, 2020
@simcha90 simcha90 changed the title feat: WIP: Waterfall chart WIP: feat: Waterfall chart Jul 27, 2020
@simcha90 simcha90 changed the title WIP: feat: Waterfall chart feat: Waterfall chart Jul 27, 2020
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #705 into master will increase coverage by 0.68%.
The diff coverage is 67.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
+ Coverage   24.19%   24.87%   +0.68%     
==========================================
  Files         339      348       +9     
  Lines        7617     7738     +121     
  Branches      925      950      +25     
==========================================
+ Hits         1843     1925      +82     
- Misses       5701     5733      +32     
- Partials       73       80       +7     
Impacted Files Coverage Δ
...ns/plugin-chart-waterfall/src/plugin/buildQuery.ts 0.00% <0.00%> (ø)
plugins/plugin-chart-waterfall/src/plugin/index.ts 33.33% <33.33%> (ø)
...in-chart-waterfall/src/components/WaterfallBar.tsx 38.88% <38.88%> (ø)
.../plugin-chart-waterfall/src/plugin/controlPanel.ts 42.85% <42.85%> (ø)
...-chart-waterfall/src/components/WaterfallChart.tsx 53.33% <53.33%> (ø)
...ins/plugin-chart-waterfall/src/components/utils.ts 66.66% <66.66%> (ø)
...lugin-chart-waterfall/src/plugin/transformProps.ts 95.12% <95.12%> (ø)
...chart-waterfall/src/components/WaterfallLegend.tsx 100.00% <100.00%> (ø)
...n-chart-waterfall/src/components/WaterfallTick.tsx 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c28e93...466e1ff. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview July 27, 2020 12:18 Inactive
@ktmud
Copy link
Contributor

ktmud commented Jul 28, 2020

Thanks for the great contribution, @amitNielsen !

Since we have plans to move Superset to ECharts, do you mind checking how much work would it be to reimplement the same visualization in ECharts?

@amitmiran137
Copy link
Contributor

amitmiran137 commented Jul 29, 2020

@ktmud in one of our community meetup it was concluded that although core plugins pack will be implemented in ECharts there would be other plugin pack and that it totally ok.

Ours going towards recharts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants