Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

ci: remove pull_request trigger #853

Merged

Conversation

nytai
Copy link
Contributor

@nytai nytai commented Dec 4, 2020

🏆 Enhancements
now that #849 has merged and the actions code is in master, we can rely on pull_request_target for any changes. pull_request will fail for any PR that comes from a fork as it will not have access to secrets needed to upload the chromatic output.

more info on pull_request_target here https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks

@vercel
Copy link

vercel bot commented Dec 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/biyt8gd4i
✅ Preview: https://superset-ui-git-tai-test-pull-request-target.superset.now.sh

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #853 (5d8500d) into master (a6286fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   26.55%   26.55%           
=======================================
  Files         377      377           
  Lines        8178     8178           
  Branches     1117     1117           
=======================================
  Hits         2172     2172           
  Misses       5878     5878           
  Partials      128      128           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6286fd...5d8500d. Read the comment docs.

@nytai nytai force-pushed the tai/test-pull-request-target branch from c9a4bc7 to 5d8500d Compare December 4, 2020 20:09
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Dec 4, 2020
@nytai nytai changed the title docs: update readme CI: remove pull_request trigger Dec 4, 2020
@nytai nytai changed the title CI: remove pull_request trigger ci: remove pull_request trigger Dec 4, 2020
@nytai nytai marked this pull request as ready for review December 4, 2020 20:19
@nytai nytai requested a review from a team as a code owner December 4, 2020 20:19
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@nytai nytai merged commit d856c4c into apache-superset:master Dec 7, 2020
@nytai nytai deleted the tai/test-pull-request-target branch December 7, 2020 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants