Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace map reduce prop in continuous ingest verify #277

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

DomGarguilo
Copy link
Member

Fixes #274

Copy link
Contributor

@dlmarion dlmarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property name looks correct for the version of Hadoop

@ctubbsii
Copy link
Member

When was this property changed in Hadoop? We need to be careful we're not breaking things with the earliest Hadoop version we still support.

@DomGarguilo
Copy link
Member Author

When was this property changed in Hadoop? We need to be careful we're not breaking things with the earliest Hadoop version we still support.

Honestly I'm not sure. I am having trouble finding what version this change happened in. I do see that the following code was from 13 years ago at which point this property was already deprecated.

https://github.com/apache/hadoop/blame/833da65d8629e0bdd79097ed26033add9fc1864f/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/util/ConfigUtil.java#L325

@ctubbsii
Copy link
Member

git tag --contains 833da65d8629e0bdd79097ed26033add9fc1864f shows that it appears in at least Hadoop 3.0.0 and newer, and we don't support anything older than that anymore, so this should be good.

@ctubbsii ctubbsii merged commit 5c642ff into apache:main Jul 23, 2024
1 check passed
@DomGarguilo DomGarguilo deleted the replaceProp branch July 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mapred.map.tasks.speculative.execution is deprecated. Instead, use mapreduce.map.speculative
3 participants