fixes sorting in bulk batch writer #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BulkBatchWriter was sorting only on the mutation row. Occasionally continuous ingest would generate the same 64 bit id twice in the same batch and if its columns were not sorted properly then the write to the rfile would fail. This fixes the problem by sorting on the entire key instead of only the row.
|
Ran continuous ingest for a bit and then verify to test these changes. |
ctubbsii
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BulkBatchWriter was sorting only on the mutation row. Occasionally continuous ingest would generate the same 64 bit id twice in the same batch and if its columns were not sorted properly then the write to the rfile would fail.
This fixes the problem by sorting on the entire key instead of only the row.