Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for Compactor process memory testing #421

Merged
merged 17 commits into from
Apr 22, 2024
Merged

Add blog post for Compactor process memory testing #421

merged 17 commits into from
Apr 22, 2024

Conversation

DomGarguilo
Copy link
Member

No description provided.

dlmarion
dlmarion reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@dlmarion dlmarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

_posts/blog/2024-04-08-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-08-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-08-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-08-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-08-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
kevinrr888 and others added 6 commits April 9, 2024 14:21
@kevinrr888
Changes:
df2e2c9 
- Findings section renamed to Conclusion and moved above Data section
- Added table of experiments performed to Data section
- Fixed some mislabled data in Data section
@DomGarguilo
Merge pull request #2 from kevinrr888/memoryReturnedBlogPostUpdates2
63d293d 
Changes
Move conclusion to bottom
0f07976
add style to images in conclusion section
3a48ead
Add helper template for two images and use it for data
5895eff
rename file to fix date
adb3362
DomGarguilo and others added 2 commits April 9, 2024 16:53
@DomGarguilo @kevinrr888
Apply suggestions from code review
487f17d 
Co-authored-by: Kevin Rathbun <43969518+kevinrr888@users.noreply.github.com>
Add JAVA_HOME step
973373f
@DomGarguilo
Copy link
Member Author

@dlmarion all of your suggestions should be addressed

@DomGarguilo DomGarguilo requested a review from dlmarion April 9, 2024 20:59
dlmarion
dlmarion approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@dlmarion dlmarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would take this out of draft for review by others.

_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
@DomGarguilo DomGarguilo marked this pull request as ready for review April 10, 2024 12:39
@kevinrr888 @DomGarguilo
Compactor Blog Post Updates (#3)
b79804e 
* goal rewording, renamed section to Test Scenario

* small grammatical error in Goal

* Update _posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md

---------

Co-authored-by: Dom G <domgarguilo@apache.org>
ctubbsii
ctubbsii reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good overall. I made a few content-based suggestions, a few style-based ones, and a few minor error corrections.

_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Show resolved Hide resolved
_includes/two_image_block.html Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
_posts/blog/2024-04-09-does-a-compactor-return-memory-to-OS.md Outdated Show resolved Hide resolved
kevinrr888 and others added 4 commits April 10, 2024 16:06
@kevinrr888
Changes: (#4)
a9cf6f5 
* Changes:

description to scripts, PID as arg, two_image_block more generic
(alt text as param and full image URL as param), fix all instances of mb
or gb when should be MB or GB.

* removed outdated echo statement
feedback incorporation
254a7d4
Merge remote-tracking branch 'origin/memoryReturnedBlogPost' into mem…
9d281a8 
…oryReturnedBlogPost
cleanup
e687393
@DomGarguilo DomGarguilo merged commit cda0457 into apache:main Apr 22, 2024
1 check passed
@DomGarguilo DomGarguilo deleted the memoryReturnedBlogPost branch April 22, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrr888 kevinrr888 kevinrr888 left review comments

@ctubbsii ctubbsii ctubbsii left review comments

@dlmarion dlmarion dlmarion approved these changes

@keith-turner keith-turner Awaiting requested review from keith-turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DomGarguilo @dlmarion @ctubbsii @kevinrr888