Modifies ColumnVisibility.normalize() to have no side effects #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColumnVisibility objects have an assoiciated parse tree. Normalizing a column visibility would change the parse tree in place. This would cause the parse tree to no longer match the expression, which would not matter for most operations on the parse tree. This side effect would also cause problems for multiple threads attempting to normalize a column visibility. This change creates a new parse tree during the normalization process and does not modify the existing one.
|
PR looks good. I'm concerned that this could cause an issue for any user that is using the parse tree after calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColumnVisibility objects have an assoiciated parse tree. Normalizing a column visibility would change the parse tree in place. This would cause the parse tree to no longer match the expression, which would not matter for most operations on the parse tree. This side effect would also cause problems for multiple threads attempting to normalize a column visibility. This change creates a new parse tree during the normalization process and does not modify the existing one.