Remove SingletonManager and related code #5282
Conversation
Remove last remaining static singleton by attaching tablet locator code to the ClientContext
|
There's still some places that look sketchy... like TabletLocator objects leaking outside try-catch blocks where the ClientContext lives. |
There was a problem hiding this comment.
There's still some places that look sketchy... like TabletLocator objects leaking outside try-catch blocks where the ClientContext lives.
The tablet locator objects could be closed when the client context is closed, causing them to throw an exception if used. That could be follow on work.
| + "disabled. This is likely caused by all AccumuloClients being closed or garbage collected"); | ||
| LocatorKey key = new LocatorKey(context.getInstanceID(), tableId); | ||
| TabletLocator tl = locators.get(key); | ||
| final var locators = context.tabletLocators(); |
There was a problem hiding this comment.
Could eventually transition away from this static synchronization and use concurrent hash map for the table map and sync in its compute function. Could also remove these static methods and transition this to the client context which internalyl uses a concurrent hash map for sync.
Wonder if the code in the method were replaced w/ a single call to client context if it would be easy to inline this method.
| @@ -340,7 +340,7 @@ private void logBusyTablets(List<ComparablePair<Long,KeyExtent>> busyTablets, | |||
| this.security = context.getSecurityOperation(); | |||
|
|
|||
| watchCriticalScheduledTask(context.getScheduledExecutor().scheduleWithFixedDelay( | |||
| TabletLocator::clearLocators, jitter(), jitter(), TimeUnit.MILLISECONDS)); | |||
| () -> TabletLocator.clearLocators(context), jitter(), jitter(), TimeUnit.MILLISECONDS)); | |||
There was a problem hiding this comment.
This may be able to be removed, needs investigation. I think the reason this code is here is that bulk v1 code would populate user tablet info in the locator cache. This would periodically clear that in case user tables were deleted to avoid memory build up. Now the tablet server should only have accumulo tables in the tablet locator cache.
Remove last remaining static singleton by attaching tablet locator code to the ClientContext