ARTEMIS-5085 use retry parameters on initial connection #5281
+58
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-5085
branch
2 times, most recently
from
f246816
to
0bf3463
Compare
tabish121
reviewed
Oct 2, 2024
| @@ -764,7 +764,7 @@ private void failoverOrReconnect(final Object connectionID, | |||
| failoverRetries++; | |||
| if (failoverRetryPredicate.test(false, failoverRetries)) { | |||
| waitForRetry(failoverRetryInterval); | |||
| failoverRetryInterval = getNextRetryInterval(failoverRetryInterval); | |||
| failoverRetryInterval = serverLocator.getNextRetryInterval(failoverRetryInterval, retryIntervalMultiplier, retryInterval); | |||
There was a problem hiding this comment.
I'm not clear on why this passes retryInterval in the function's (maxRetryInterval) argument vs passing the configured maxRetryInterval, is that intentional ?
There was a problem hiding this comment.
It's a bug. Nice catch!
When the Core client attempts to create the initial connection to a broker when initialConnectAttempts > 1 it will adhere to retryInterval, but it will ignore retryIntervalMultiplier & maxRetryInterval. This commit fixes that so that these parameters are taken into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Core client attempts to create the initial connection to a broker when initialConnectAttempts > 1 it will adhere to retryInterval, but it will ignore retryIntervalMultiplier & maxRetryInterval. This commit fixes that so that these parameters are taken into account.