Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARTEMIS-5141 Add or remove plugins on configuration reload #5333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ARTEMIS-5141 Add or remove plugins on configuration reload #5333

wants to merge 1 commit into from

Conversation

AntonRoskvist
Copy link
Contributor

No description provided.

brusdev
brusdev reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@brusdev brusdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method registered of the reloaded broker plugins is not invoked.

The existing broker plugins in the config are unregistered and registered on the config reload. Is that on purpose?

...tion-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java
embeddedActiveMQ.getActiveMQServer().getReloadManager().setTick(tick);
latch.await(10, TimeUnit.SECONDS);

assertEquals(1, embeddedActiveMQ.getActiveMQServer().getBrokerPlugins().size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is embeddedActiveMQ.getActiveMQServer().getBrokerPlugins().size() == 1 after the configuration reload?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments clarifying this.

I start the broker without any plugins.
I add one plugin programmatically (which should not be affected by following configuration reloads).
I add one plugin through configuration, then remove the same plugin through configuration.

The final assert is then to verify that the programmatically added plugin stayed registered.

@AntonRoskvist
Copy link
Contributor Author

The method registered of the reloaded broker plugins is not invoked.

The existing broker plugins in the config are unregistered and registered on the config reload. Is that on purpose?

That is not intentional, thanks for catching that @brusdev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusdev brusdev brusdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonRoskvist @brusdev