Artemis Console next gen based on hawtIO 4 #5467
Conversation
andytaylor
force-pushed
the
console-upgrade
branch
4 times, most recently
from
d6d03ac to
bbcd1d4
Compare
|
|
||
|
|
||
| public void loadLandingPage() { |
There was a problem hiding this comment.
could the loadLandingPage method be moved to ConsoleTest class?
There was a problem hiding this comment.
actually it should be an abstract method in consoleTest that is implemented differently in ArtemisTest and ArtemisJMXTest (for when I add more tests), wdyt?
andytaylor
force-pushed
the
console-upgrade
branch
3 times, most recently
from
9bdb0a1 to
9935414
Compare
andytaylor
force-pushed
the
console-upgrade
branch
2 times, most recently
from
acf9c8f to
0c0edfd
Compare
andytaylor
force-pushed
the
console-upgrade
branch
from
0c0edfd to
200a471
Compare
| <artifactId>apache-artemis-console</artifactId> | ||
| <type>zip</type> | ||
| <classifier>bin</classifier> |
There was a problem hiding this comment.
Carried over comment (there are others) from previous PR:
(Thinking on it again, I think removing it should probably be the way to go)
The changes in the pom overall result in inclusion of the console zip and the war in the distribution lib dir.
This should probably marked as provided as its only here for build time use (or maybe it could even be omitted, given it is specified in the dependency unpack execution)
No description provided.