ARTEMIS-5253 improve referencability of RA ConnectionFactory #5576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabish121
reviewed
Mar 25, 2025
| @@ -39,7 +39,7 @@ public ActiveMQRAConnectionManager() { | |||
| logger.trace("constructor()"); | |||
| } | |||
|
|
|||
| ConcurrentHashSet<ManagedConnection> connections = new ConcurrentHashSet<>(); | |||
| transient ConcurrentHashSet<ManagedConnection> connections = new ConcurrentHashSet<>(); | |||
There was a problem hiding this comment.
My recollection of Serialization code (which is pretty foggy) is that when you do this the value of the connections variable will be null after readObject is called regardless of the initialization here and you would need to add an override of readObject to initialize the value of connections:
private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
in.defaultReadObject();
connections = new ConcurrentHashSet<>();
}
Same holds true for some of the other new transient collections added below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.