Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-5364 clean up scripts & profiles #5578

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbertram
Copy link
Contributor

@jbertram jbertram commented Mar 22, 2025

This commit cleans up the various scripts and profile files via the following changes:

  • Remove ARTEMIS_INSTANCE_URI from all profiles since it is no longer used after we moved to Log4j2
  • Remove ARTEMIS_INSTANCE_ETC_URI from all profiles; it is not necessary because the jolokia-access.xml can be loaded directly from the classpath
  • Remove ARTEMIS_ETC_DIR from all profiles and instead rely on ARTEMIS_INSTANCE_ETC which is already being set in the scripts
  • Remove unnecessary code from Create command
  • Remove ARTEMIS_OOME_DUMP from the utility profiles since it's not used
  • Adjust Upgrade command & related tests
  • Fix Windows service file so it uses the same memory settings as the other configs
  • Update the Windows' profile JAVA_ARGS to match those from Linux

@jbertram jbertram force-pushed the ARTEMIS-5364 branch 2 times, most recently from 6259320 to f15403f Compare March 22, 2025 15:15
@jbertram jbertram marked this pull request as draft March 22, 2025 16:01
@jbertram jbertram force-pushed the ARTEMIS-5364 branch 2 times, most recently from fac489d to 267c065 Compare March 22, 2025 19:46
@jbertram jbertram changed the title ARTEMIS-5364 clean up profiles ARTEMIS-5364 clean up scripts & profiles Mar 22, 2025
This commit cleans up the various scripts and profile files via the
following changes:

 - Remove ARTEMIS_INSTANCE_URI from all profiles since it is no longer
   used after we moved to Log4j2
 - Remove ARTEMIS_INSTANCE_ETC_URI from all profiles; it is not
   necessary because the jolokia-access.xml can be loaded directly
   from the classpath
 - Remove ARTEMIS_ETC_DIR from all profiles and instead rely on
   ARTEMIS_INSTANCE_ETC which is already being set in the scripts
 - Remove unnecessary code from Create command
 - Remove ARTEMIS_OOME_DUMP from the utility profiles since it's not
   used
 - Adjust Upgrade command & related tests
 - Fix Windows service file so it uses the same memory settings as
   the other configs
 - Update the Windows' profile JAVA_ARGS to match those from Linux
@jbertram jbertram marked this pull request as ready for review March 23, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant