Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMQ-9643] Add design doc for supporting hashed credential in PropertiesLoginModule #1400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kenliao94
Copy link
Contributor

Design doc for supporting AMQ-9643

@jbonofre
Copy link
Member

jbonofre commented Mar 5, 2025

I would suggest to mimic what I did in Apache Karaf (https://github.com/apache/karaf/blob/main/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java).
Basically, I have on thread that scan the properties file, and if it detects non encrypted password (e.g without the prefix), then it does the encryption and "flag" the password with the prefix (indicating it's a hash).

@kenliao94
Copy link
Contributor Author

I would suggest to mimic what I did in Apache Karaf (https://github.com/apache/karaf/blob/main/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java).
Basically, I have on thread that scan the properties file, and if it detects non encrypted password (e.g without the prefix), then it does the encryption and "flag" the password with the prefix (indicating it's a hash).

Hey @jbonofre thanks for the review. I am not following. If a password doesn't have the prefix, then we assume it is just plaintext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants