MERGE followed by SET causes segfault

[bravius]

Describe the bug

MERGE followed by SET causes server process segfault.

How are you accessing AGE (Command line, driver, etc.)?

Bundled Node 'pg-age' driver.

What data setup do we need to do?

...
SELECT create_graph('test');
SELECT create_vlabel('test', 'node');
SELECT * FROM cypher('test', $$ CREATE (n:node {name: 'Jason'}) RETURN n $$) AS (n agtype);
...

What is the necessary configuration info needed?

None.

What is the command that caused the error?

SELECT * FROM cypher('test', $$ MERGE (n:node {name: 'Jason'}) SET n.name = 'Lisa' RETURN n $$) AS (n agtype);

NOTE: If the node exists, the server process crashes. However, if the node does not exist, the MERGE query completes successfully.

log dump

LOG:  server process (PID 4853) was terminated by signal 11: Segmentation fault

DETAIL:  Failed process was running: SELECT * FROM cypher('test', $$ MERGE (n:node {name: 'Jason'}) SET n.name = 'Lisa' RETURN n $$) AS (n agtype)

LOG:  terminating any other active server processes

WARNING:  terminating connection because of crash of another server process

DETAIL:  The postmaster has commanded this server process to roll back the current transaction and exit, because another server process exited abnormally and possibly corrupted shared memory.

HINT:  In a moment you should be able to reconnect to the database and repeat your command.

LOG:  all server processes terminated; reinitializing

LOG:  database system was interrupted; last known up at 2022-06-20 20:15:58 UTC

FATAL:  the database system is in recovery mode

LOG:  database system was not properly shut down; automatic recovery in progress

LOG:  redo starts at 0/521B0A0

LOG:  invalid record length at 0/526E288: wanted 24, got 0

LOG:  redo done at 0/526E250

LOG:  last completed transaction was at log time 2022-06-20 20:16:12.938992+00

LOG:  database system is ready to accept connections

Expected behavior

Execute cypher query with no crashy crashy.

Environment (please complete the following information):

• postgresql with AGE extension running in a Docker container, on Windows 10 and WSL2
• compiled AGE extension from master

Additional context

None.

[jrgemignani]

Was able to reproduce the bug. Will look into a fix.

[pdpotter]

Could this be related to #232 (comment), where the return value differs depending on whether a node exists before executing a MERGE?

[jrgemignani]

Not sure, this appears to be specifically related to SET

[jrgemignani]

A patch is currently in review to correct this issue.

[jrgemignani]

Could this be related to #232 (comment), where the return value differs depending on whether a node exists before executing a MERGE?

This might address that issue. But, #232 is lacking clears examples to know for sure.

[jrgemignani]

This is now fixed in the master branch. It also fixes #232.

[bravius]

Resolved, thank you.