Airavata 3594 admin dashboard additions #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 13, 2023 00:45
…implementation in RegistryServerHandler to be done
SauravKumarJhaNITW
force-pushed
the
AIRAVATA-3594-admin-dashboard-additions
branch
from
266f0e7 to
b0f1af5
Compare
machristie
requested changes
Aug 31, 2023
There was a problem hiding this comment.
Hi @SauravKumarJhaNITW , thank you for this contribution! Overall this looks really good. I do have some requested changes in my review mainly around making sure that the getCpuUsage code can scale to handle gateways with thousands of jobs. Please let me know if you have any questions.
...main/java/org/apache/airavata/registry/core/repositories/expcatalog/JobStatusRepository.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/airavata/registry/core/repositories/expcatalog/JobStatusRepository.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/airavata/registry/core/repositories/expcatalog/JobStatusRepository.java
Outdated
Show resolved
Hide resolved
|
Thanks a lot @machristie for your comments. Comments were very easy to follow along, really appreciated. I have made changes based on those. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was raised during Google Summer of Code 2023
It contains methods, models, configurations which was the requirements of Airavata-3594 Jira EPIC
added a method to return UserGroups filtered by creation date
added a method to return cpuUsages within the specified date, corresponding models and configurations