Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade FAB to 4.5.1
Browse files Browse the repository at this point in the history
FAB 4.5.1 has been released in September with a few small
fixes. This change updates fab to 4.5.1 including changing the
rate limiter creation that is vendored in. It has been changed
in dpgaspar/Flask-AppBuilder#2254 and
relased in 4.5.1. That's the only dfference in security manager
between 4.5.0 and 4.5.1.
potiuk committed Oct 22, 2024
1 parent ccd7b86 commit 1996e78
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions airflow/www/security_manager.py
Original file line number Diff line number Diff line change
@@ -108,8 +108,9 @@ def before_request():
g.user = get_auth_manager().get_user()

def create_limiter(self) -> Limiter:
limiter = Limiter(key_func=get_remote_address)
limiter.init_app(self.appbuilder.get_app)
app = self.appbuilder.get_app
limiter = Limiter(key_func=app.config.get("RATELIMIT_KEY_FUNC", get_remote_address))
limiter.init_app(app)
return limiter

def register_views(self):
2 changes: 1 addition & 1 deletion generated/provider_dependencies.json
Original file line number Diff line number Diff line change
@@ -572,7 +572,7 @@
"deps": [
"apache-airflow-providers-common-compat>=1.2.1",
"apache-airflow>=2.9.0",
"flask-appbuilder==4.5.0",
"flask-appbuilder==4.5.1",
"flask-login>=0.6.2",
"flask>=2.2,<2.3",
"google-re2>=1.0",
2 changes: 1 addition & 1 deletion providers/src/airflow/providers/fab/provider.yaml
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ dependencies:
# Every time we update FAB version here, please make sure that you review the classes and models in
# `airflow/providers/fab/auth_manager/security_manager/override.py` with their upstream counterparts.
# In particular, make sure any breaking changes, for example any new methods, are accounted for.
- flask-appbuilder==4.5.0
- flask-appbuilder==4.5.1
- flask-login>=0.6.2
- google-re2>=1.0
- jmespath>=0.7.0

0 comments on commit 1996e78

Please sign in to comment.