[AIRFLOW-4524] Fix incorrect field names in view for Mark Success/Fai…

…lure (#5486)

Another mistake that wasn't caught from #5039 - we renamed the fields
in the template (to be unique) but didn't update the view

(cherry picked from commit 6afb12f)

airflow/www/views.py

@@ -1435,10 +1435,10 @@ def failed(self):
  execution_date = request.form.get('execution_date')
 
  confirmed = request.form.get('confirmed') == "true"
- upstream = request.form.get('upstream') == "true"
- downstream = request.form.get('downstream') == "true"
- future = request.form.get('future') == "true"
- past = request.form.get('past') == "true"
+ upstream = request.form.get('failed_upstream') == "true"
+ downstream = request.form.get('failed_downstream') == "true"
+ future = request.form.get('failed_future') == "true"
+ past = request.form.get('failed_past') == "true"
 
  return self._mark_task_instance_state(dag_id, task_id, origin, execution_date,
  confirmed, upstream, downstream,
@@ -1455,10 +1455,10 @@ def success(self):
  execution_date = request.form.get('execution_date')
 
  confirmed = request.form.get('confirmed') == "true"
- upstream = request.form.get('upstream') == "true"
- downstream = request.form.get('downstream') == "true"
- future = request.form.get('future') == "true"
- past = request.form.get('past') == "true"
+ upstream = request.form.get('success_upstream') == "true"
+ downstream = request.form.get('success_downstream') == "true"
+ future = request.form.get('success_future') == "true"
+ past = request.form.get('success_past') == "true"
 
  return self._mark_task_instance_state(dag_id, task_id, origin, execution_date,
  confirmed, upstream, downstream,

airflow/www_rbac/views.py

@@ -1166,10 +1166,10 @@ def failed(self):
  execution_date = request.form.get('execution_date')
 
  confirmed = request.form.get('confirmed') == "true"
- upstream = request.form.get('upstream') == "true"
- downstream = request.form.get('downstream') == "true"
- future = request.form.get('future') == "true"
- past = request.form.get('past') == "true"
+ upstream = request.form.get('failed_upstream') == "true"
+ downstream = request.form.get('failed_downstream') == "true"
+ future = request.form.get('failed_future') == "true"
+ past = request.form.get('failed_past') == "true"
 
  return self._mark_task_instance_state(dag_id, task_id, origin, execution_date,
  confirmed, upstream, downstream,
@@ -1186,10 +1186,10 @@ def success(self):
  execution_date = request.form.get('execution_date')
 
  confirmed = request.form.get('confirmed') == "true"
- upstream = request.form.get('upstream') == "true"
- downstream = request.form.get('downstream') == "true"
- future = request.form.get('future') == "true"
- past = request.form.get('past') == "true"
+ upstream = request.form.get('success_upstream') == "true"
+ downstream = request.form.get('success_downstream') == "true"
+ future = request.form.get('success_future') == "true"
+ past = request.form.get('success_past') == "true"
 
  return self._mark_task_instance_state(dag_id, task_id, origin, execution_date,
  confirmed, upstream, downstream,