Skip to content

Commit

Permalink
[v2-10-test] Random doc typos (#44750) (#44758)
Browse files Browse the repository at this point in the history
* Random doc typos

* Update contributing-docs/testing/unit_tests.rst

* Update contributing-docs/testing/unit_tests.rst

---------

(cherry picked from commit 909ff71)

Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
(cherry picked from commit b5f033a)
  • Loading branch information
github-actions[bot] authored and utkarsharma2 committed Dec 10, 2024
1 parent 1dc0cc4 commit 4f9cf54
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions contributing-docs/testing/unit_tests.rst
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,10 @@ If your test accesses the database but is not marked properly the Non-DB test in
How to verify if DB test is correctly classified
................................................

When you add if you want to see if your DB test is correctly classified, you can run the test or group
If you want to see if your DB test is correctly classified, you can run the test or group
of tests with ``--skip-db-tests`` flag.

You can run the all (or subset of) test types if you want to make sure all ot the problems are fixed
You can run the all (or subset of) test types if you want to make sure all of the problems are fixed

.. code-block:: bash
Expand Down Expand Up @@ -502,8 +502,8 @@ Do this:
Problems with Non-DB test collection
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Sometimes, even if whole module is marked as ``@pytest.mark.db_test`` even parsing the file and collecting
tests will fail when ``--skip-db-tests`` is used because some of the imports od objects created in the
Sometimes, even if the whole module is marked as ``@pytest.mark.db_test``, parsing the file and collecting
tests will fail when ``--skip-db-tests`` is used because some of the imports or objects created in the
module will read the database.

Usually what helps is to move such initialization code to inside the tests or pytest fixtures (and pass
Expand Down Expand Up @@ -1162,9 +1162,9 @@ directly to the container.
Implementing compatibility for provider tests for older Airflow versions
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When you implement tests for providers, you should make sure that they are compatible with older
When you implement tests for providers, you should make sure that they are compatible with older Airflow versions.
Note that some of the tests if written without taking care about the compatibility, might not work with older
Note that some of the tests, if written without taking care about the compatibility, might not work with older
versions of Airflow - this is because of refactorings, renames, and tests relying on internals of Airflow that
are not part of the public API. We deal with it in one of the following ways:
Expand Down

0 comments on commit 4f9cf54

Please sign in to comment.