fix values-schema, imporove comments

apache · Jun 24, 2024 · a2afc9e · a2afc9e
1 parent 9cd8177
commit a2afc9e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 39 deletions.
diff --git a/chart/values.schema.json b/chart/values.schema.json
@@ -1602,25 +1602,8 @@
                             "default": true
                         },
                         "persistentVolumeClaimRetentionPolicy": {
-                            "description": "How PVCs are deleted during the lifecycle of a StatefulSet",
-                            "type": [
-                                "object",
-                                "null"
-                            ],
-                            "default": null,
-                            "additionalProperties": false,
-                            "properties": {
-                                "whenDeleted": {
-                                    "description": "Whether to retain the PVC when the StatefulSet is deleted.",
-                                    "type": "string",
-                                    "default": "Retain"
-                                },
-                                "whenScaled": {
-                                    "description": "Whether to retain the PVC when the StatefulSet is scaled.",
-                                    "type": "string",
-                                    "default": "Retain"
-                                }
-                            }
+                            "$ref": "#/definitions/persistentVolumeClaimRetentionPolicy",
+                            "description": "PersistentVolumeClaim retention policy to be used in the lifecycle of a StatefulSet"
                         },
                         "size": {
                             "description": "Volume size for worker StatefulSet.",
@@ -2968,24 +2951,8 @@
                             "default": "100Gi"
                         },
                         "persistentVolumeClaimRetentionPolicy": {
-                            "description": "How PVCs are deleted during the lifecycle of a StatefulSet",
-                            "type": [
-                                "object",
-                                "null"
-                            ],
-                            "additionalProperties": false,
-                            "properties": {
-                                "whenDeleted": {
-                                    "description": "Whether to retain the PVC when the StatefulSet is deleted.",
-                                    "type": "string",
-                                    "default": "Retain"
-                                },
-                                "whenScaled": {
-                                    "description": "Whether to retain the PVC when the StatefulSet is scaled.",
-                                    "type": "string",
-                                    "default": "Retain"
-                                }
-                            }
+                            "$ref": "#/definitions/persistentVolumeClaimRetentionPolicy",
+                            "description": "PersistentVolumeClaim retention policy to be used in the lifecycle of a StatefulSet"
                         },
                         "storageClassName": {
                             "description": "If using a custom StorageClass, pass name ref to all StatefulSets here.",
@@ -11876,6 +11843,27 @@
                     }
                 }
             }
+        },
+        "persistentVolumeClaimRetentionPolicy": {
+            "description": "PersistentVolumeClaim retention policy to be used in the lifecycle of a StatefulSet",
+            "type": [
+                "object",
+                "null"
+            ],
+            "default": null,
+            "additionalProperties": false,
+            "properties": {
+                "whenDeleted": {
+                    "description": "Whether to retain the PVC when the StatefulSet is deleted.",
+                    "type": "string",
+                    "default": "Retain"
+                },
+                "whenScaled": {
+                    "description": "Whether to retain the PVC when the StatefulSet is scaled.",
+                    "type": "string",
+                    "default": "Retain"
+                }
+            }
         }
     }
 }
diff --git a/chart/values.yaml b/chart/values.yaml
@@ -619,7 +619,7 @@ workers:
   persistence:
     # Enable persistent volumes
     enabled: true
-    # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled/removed
+    # This policy determines whether PVCs should be deleted when StatefulSet is scaled down or removed.
     persistentVolumeClaimRetentionPolicy: ~
     # persistentVolumeClaimRetentionPolicy:
     #   whenDeleted: Delete
@@ -1537,7 +1537,7 @@ triggerer:
   persistence:
     # Enable persistent volumes
     enabled: true
-    # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled/removed
+    # This policy determines whether PVCs should be deleted when StatefulSet is scaled down or removed.
     persistentVolumeClaimRetentionPolicy: ~
     # Volume size for triggerer StatefulSet
     size: 100Gi