Skip to content

Commit

Permalink
More explicit zindex on modals
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Mar 10, 2016
1 parent db9b48d commit c70d354
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion airflow/www/static/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ a.navbar-brand span {
color: white;
}
.modal-backdrop{
z-index: 10;
z-index: 0;
}
.modal-content{
z-index: 5;
}
nav{
-webkit-box-shadow: 0px 3px 3px #AAA;
Expand Down

3 comments on commit c70d354

@abridgett
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. With both Chrome (49.0.2623.87 Mac) and Firefox (38.0.5 Mac):

  • fix above is good
  • just modal-backdrop z-index 0 (no modal-content) is also good
  • no modal-backdrop at all is good
  • modal-backdrop z-index 10 is bad

(Testing on the graph view - if there's a different place/problem you would like to check then I'm more than happy to test elsewhere too)

@abridgett
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Gosh, my firefox was a tad outdated) - proposed fix also good on v45 :)

@thibault-ketterer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, I didn't want to mess with your css
ok for me
Linux

  • chrome Version 49.0.2623.75 (64-bit)
  • old iceweasel 37
  • firefox 42
  • firefox 45

Please sign in to comment.