Adding url sanitisation for extra links (#41665) (#41680)

(cherry picked from commit 6c463b3)
apache · Sep 2, 2024 · ceb6051 · ceb6051
1 parent 400dddc
commit ceb6051
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx b/airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
@@ -53,6 +53,14 @@ const ExtraLinks = ({
   const isExternal = (url: string | null) =>
     url && /^(?:[a-z]+:)?\/\//.test(url);
 
+  const isSanitised = (url: string | null) => {
+    if (!url) {
+      return true;
+    }
+    const urlRegex = /^(https?:)/i;
+    return urlRegex.test(url);
+  };
+
   return (
     <Box my={3}>
       <Text as="strong">Extra Links</Text>
@@ -63,7 +71,7 @@ const ExtraLinks = ({
             as={Link}
             colorScheme="blue"
             href={url}
-            isDisabled={!url}
+            isDisabled={!isSanitised(url)}
             target={isExternal(url) ? "_blank" : undefined}
             mr={2}
           >